Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cacheHandler checking #253

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Added cacheHandler checking #253

merged 1 commit into from
Oct 6, 2020

Conversation

jordi735
Copy link
Contributor

@jordi735 jordi735 commented Oct 6, 2020

  • Added check in CdnManager.java
  • Added check in AudioFileStreaming.java

this commit fixes #252

+ Added check in CdnManager.java
+ Added check in AudioFileStreaming.java
@devgianlu devgianlu merged commit dfc88a2 into librespot-org:dev Oct 6, 2020
devgianlu added a commit that referenced this pull request Nov 17, 2020
* [ci skip] Bump to snapshot version

* Added #waitReady() method to avoid using player before initialization

* Updated disclaimer

* Make sure that cache files and queue entries are closed

* Fixed NPE

* Added cacheHandler checking (#253)

+ Added check in CdnManager.java
+ Added check in AudioFileStreaming.java

* Fixed NPE when skipping before song loaded

* Added pass through endpoint to API (#255)

* Handle null `player_options_override` (#254)

* Do not pause if not specified (#254)

* Fixed tests path

* Added hash check for first chunk of cached data

* Bump commons-net from 3.6 to 3.7.2 (#256)

Bumps commons-net from 3.6 to 3.7.2.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump annotations from 19.0.0 to 20.1.0 (#257)

Bumps [annotations](https://github.com/JetBrains/java-annotations) from 19.0.0 to 20.1.0.
- [Release notes](https://github.com/JetBrains/java-annotations/releases)
- [Changelog](https://github.com/JetBrains/java-annotations/blob/master/CHANGELOG.md)
- [Commits](JetBrains/java-annotations@19.0.0...20.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump protobuf-java from 3.12.2 to 3.14.0 (#258)

Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.12.2 to 3.14.0.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.12.2...v3.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump junit-jupiter from 5.6.2 to 5.7.0 (#259)

Bumps [junit-jupiter](https://github.com/junit-team/junit5) from 5.6.2 to 5.7.0.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.6.2...r5.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump maven-javadoc-plugin from 3.1.1 to 3.2.0 (#260)

Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.1.1 to 3.2.0.
- [Release notes](https://github.com/apache/maven-javadoc-plugin/releases)
- [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.1.1...maven-javadoc-plugin-3.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Release 1.5.2

Co-authored-by: Jordi735 <jordidorren@gmail.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException when not having cache enabled.
2 participants