feat(BUMP): implementation of NewBUMPFromStream that returns bytes used #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkadiuszos4chain
approved these changes
May 22, 2024
|
All good, thanks. Probably will ask you to refactor with go-sdk one day in future, but I think they will work from this so it'll be the same code. |
boecklim
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done
A new function
NewBUMPFromStreamwas created with the same functionality asNewBUMPFromBytes, except it returns a number of bytes used.This was modelled on
NewTxFromStreamfrom go-bt.The signature of
NewBUMPFromByteswas untouched for backwards compatibility.Why?
In order to make it easier to parse BUMPs from BEEF and avoid repeating this parsing in SPV, go-bc and Arc :)