Fix panic in ToAsm() caused by last commit. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadwahab
approved these changes
Mar 19, 2022
ordishs
added a commit
to ordishs/go-bt
that referenced
this pull request
Mar 22, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
#130) * Merge branch 'master' of https://github.com/libsv/go-bt * Fix panic in ToAsm() caused by last commit. (#109) * Fix rename of variable * Fixed an old test that was failing due to changes in ToAsm() method * Explicity check error * Spelling * All transaction parsing functions now use one function. Added BIP-239 support (extended transaction format) * Add comments and extra test * Overcome linter * Linter workarounds * Linter fix * More linting workarounds * Minor changes to address comments in PR
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
* Merge branch 'master' of https://github.com/libsv/go-bt * Fix panic in ToAsm() caused by last commit. (#109) * Fix rename of variable * Fixed an old test that was failing due to changes in ToAsm() method * Explicity check error * Spelling * All transaction parsing functions now use one function. Added BIP-239 support (extended transaction format) * Add comments and extra test * Overcome linter * Linter workarounds * Linter fix * More linting workarounds * Minor changes to address comments in PR * Make CreateOpReturnOutput public * Added comment to CreateOpReturnOutput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.