Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP_CODESEPARATOR bug fix #164

Merged
merged 4 commits into from
Jul 28, 2023
Merged

OP_CODESEPARATOR bug fix #164

merged 4 commits into from
Jul 28, 2023

Commits on Jul 26, 2023

  1. OP_CODESEPARATOR bug fix 

    Off by one bug, the subscript does not include the opcode separator itself, so the slice of the script should be from just after the op code separator - not before.

This took about 16 hours to find 😫

Signed-off-by: Darren Kellenschwiler <deggen@kschw.com>
    @sirdeggen
    sirdeggen committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4669dcd View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. BPAAS-875: unit test for failing script evaluation

    @boecklim
    boecklim committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    f9ae214 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #166 from boecklim/fix/interpreter-bug-op-code-sep… 

    …arator-test

BPAAS-875: unit test for failing script evaluation
    deggen authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    7051fc5 View commit details
    Browse the repository at this point in the history

  3. test passes 

    Signed-off-by: Darren Kellenschwiler <deggen@kschw.com>
    @sirdeggen
    sirdeggen committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9ef4e75 View commit details
    Browse the repository at this point in the history