-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/fee quotes #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, you just opened your first pull request on libsv/libsv! Thank you for contributing!
…eQuotes per miner. Added addtional tests
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 78.18% 78.58% +0.40%
==========================================
Files 18 18
Lines 1100 1158 +58
==========================================
+ Hits 860 910 +50
- Misses 161 165 +4
- Partials 79 83 +4
Continue to review full report at Codecov.
|
14624c0
to
835f0a1
Compare
LGTM, just need to sort the merge conflicts with lastest master and we should be good to go! @theflyingcodr |
This rejigs the Fees a bit and encapsulates the maps etc behind a (hopefully) friendlier API.
It has been extensively documented with godoc comments but it brings in: