Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/fee quotes #18

Merged
merged 17 commits into from
Aug 18, 2021
Merged

Enhancement/fee quotes #18

merged 17 commits into from
Aug 18, 2021

Conversation

theflyingcodr
Copy link
Contributor

@theflyingcodr theflyingcodr commented Apr 13, 2021

This rejigs the Fees a bit and encapsulates the maps etc behind a (hopefully) friendlier API.

It has been extensively documented with godoc comments but it brings in:

  • cache quotes from multiple miners
  • or use FeeQuote if you only work with one miner
  • expiry time for quotes
  • easy easy way to add / update a quote/s
  • easy way to change quote/s expiry time
  • if using FeeQuotes, convenience methods to get fees and update fees

@theflyingcodr theflyingcodr added the enhancement New feature or request label Apr 13, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats, you just opened your first pull request on libsv/libsv! Thank you for contributing!

fees.go Outdated Show resolved Hide resolved
fees.go Outdated Show resolved Hide resolved
fees.go Outdated Show resolved Hide resolved
@theflyingcodr theflyingcodr self-assigned this May 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #18 (8ec856a) into master (d161baa) will increase coverage by 0.40%.
The diff coverage is 89.28%.

❗ Current head 8ec856a differs from pull request most recent head 6285416. Consider uploading reports for the commit 6285416 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   78.18%   78.58%   +0.40%     
==========================================
  Files          18       18              
  Lines        1100     1158      +58     
==========================================
+ Hits          860      910      +50     
- Misses        161      165       +4     
- Partials       79       83       +4     
Impacted Files Coverage Δ
bscript/address.go 85.96% <ø> (ø)
fees.go 91.39% <89.04%> (-8.61%) ⬇️
txchange.go 78.37% <90.90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d161baa...6285416. Read the comment docs.

@theflyingcodr theflyingcodr changed the base branch from v2 to master August 11, 2021 13:11
@jadwahab
Copy link
Member

LGTM, just need to sort the merge conflicts with lastest master and we should be good to go! @theflyingcodr

@mergify mergify bot added the feature label Aug 18, 2021
@mergify mergify bot merged commit e0da228 into master Aug 18, 2021
@mergify mergify bot deleted the enhancement/FeeQuotes branch August 18, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants