Bec v2 #20
Merged
Bec v2 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which contains crypto and key functions used by BT
…lace with String implementing Stringer
Codecov Report
@@ Coverage Diff @@
## v2 #20 +/- ##
==========================================
+ Coverage 75.89% 76.46% +0.56%
==========================================
Files 20 18 -2
Lines 809 786 -23
==========================================
- Hits 614 601 -13
+ Misses 132 120 -12
- Partials 63 65 +2
Continue to review full report at Codecov.
|
adding changeToAddress (backport from v1)
jadwahab
approved these changes
May 10, 2021
bscript/script.go
Outdated
| @@ -315,3 +313,20 @@ func (s *Script) PublicKeyHash() ([]byte, error) { | |||
|
|
|||
| return parts[0], nil | |||
| } | |||
|
|
|||
| // Equals will compare the script to b and return true if they match. | |||
| func (s *Script) Equals(b *Script) bool{ | |||
There was a problem hiding this comment.
remember to add tests for these
…which contains crypto and key functions used by BT
…lace with String implementing Stringer
jadwahab
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the new go-bk dependency and remove all other dependencies go-bt had.
bk contains crypto functions as well as key related functions such as bip32 etc.
bt has now been cleaned out of all these functions making it more targeted purely to transaction building and scripts.