Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/p2pkhbytelen #31

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Fix/p2pkhbytelen #31

merged 3 commits into from
Jul 26, 2021

Conversation

theflyingcodr
Copy link
Contributor

We were missing the varint byte when calculating change length, this adds that in.

@theflyingcodr theflyingcodr self-assigned this Jul 26, 2021
@theflyingcodr theflyingcodr added the bug Something isn't working label Jul 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2021

Codecov Report

Merging #31 (aba1414) into master (4445010) will increase coverage by 2.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   76.83%   79.30%   +2.46%     
==========================================
  Files          16       16              
  Lines         885     1029     +144     
==========================================
+ Hits          680      816     +136     
- Misses        139      147       +8     
  Partials       66       66              
Impacted Files Coverage Δ
tx.go 81.34% <100.00%> (+3.16%) ⬆️
fees.go 100.00% <0.00%> (ø)
varint.go 100.00% <0.00%> (ø)
crypto/hash.go 100.00% <0.00%> (ø)
bytemanipulation.go 100.00% <0.00%> (ø)
input.go 83.33% <0.00%> (+1.07%) ⬆️
output.go 84.15% <0.00%> (+1.20%) ⬆️
crypto/encryption.go 88.23% <0.00%> (+1.56%) ⬆️
bscript/address.go 85.96% <0.00%> (+1.96%) ⬆️
bscript/oppushdata.go 72.83% <0.00%> (+2.17%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4445010...aba1414. Read the comment docs.

@jadwahab jadwahab merged commit 78c9d18 into master Jul 26, 2021
@jadwahab jadwahab deleted the fix/p2pkhbytelen branch July 26, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants