Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/v2 p2pkhbytelen #32

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Fix/v2 p2pkhbytelen #32

merged 1 commit into from
Jul 26, 2021

Conversation

theflyingcodr
Copy link
Contributor

Adds the missing varint

@theflyingcodr theflyingcodr changed the base branch from master to v2 July 26, 2021 08:28
@codecov-commenter
Copy link

Codecov Report

Merging #32 (bad55a6) into v2 (b2889d5) will increase coverage by 2.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2      #32      +/-   ##
==========================================
+ Coverage   75.45%   77.81%   +2.35%     
==========================================
  Files          18       18              
  Lines         925     1073     +148     
==========================================
+ Hits          698      835     +137     
- Misses        149      160      +11     
  Partials       78       78              
Impacted Files Coverage Δ
txchange.go 75.90% <100.00%> (+3.68%) ⬆️
fees.go 100.00% <0.00%> (ø)
varint.go 100.00% <0.00%> (ø)
bytemanipulation.go 100.00% <0.00%> (ø)
input.go 79.36% <0.00%> (+0.05%) ⬆️
output.go 87.30% <0.00%> (+1.33%) ⬆️
tx.go 82.05% <0.00%> (+1.63%) ⬆️
signaturehash.go 84.00% <0.00%> (+1.91%) ⬆️
bscript/address.go 85.96% <0.00%> (+1.96%) ⬆️
bscript/oppushdata.go 72.83% <0.00%> (+2.17%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2889d5...bad55a6. Read the comment docs.

@theflyingcodr theflyingcodr added the bug Something isn't working label Jul 26, 2021
@jadwahab jadwahab merged commit 7358e36 into v2 Jul 26, 2021
@jadwahab jadwahab deleted the fix/v2_p2pkhbytelen branch July 26, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants