Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change calc update #33

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Change calc update #33

merged 1 commit into from
Aug 11, 2021

Conversation

theflyingcodr
Copy link
Contributor

Fees for change were using the wrong size for the input sig, that has now been adjusted to 71 bytes.

Some of the fee calcs were done in two places, as these round down, they sometimes resulted in the change being 1 satoshi too high which could impact the fee rate. Now moved the actual fee calc to one place to avoid this issue.

…er input. Adjusting fee calcs for bytes and std to do the calc in one place to avoid rounding issues
@theflyingcodr theflyingcodr self-assigned this Aug 10, 2021
@theflyingcodr theflyingcodr added the bug Something isn't working label Aug 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #33 (57d82cc) into v2 (97fd3b2) will increase coverage by 0.18%.
The diff coverage is 62.50%.

❗ Current head 57d82cc differs from pull request most recent head 5b1443a. Consider uploading reports for the commit 5b1443a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##               v2      #33      +/-   ##
==========================================
+ Coverage   77.99%   78.18%   +0.18%     
==========================================
  Files          18       18              
  Lines        1109     1100       -9     
==========================================
- Hits          865      860       -5     
+ Misses        163      161       -2     
+ Partials       81       79       -2     
Impacted Files Coverage Δ
txchange.go 78.37% <62.50%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97fd3b2...5b1443a. Read the comment docs.

@theflyingcodr theflyingcodr changed the base branch from v2 to master August 11, 2021 13:11
@jadwahab jadwahab merged commit 64e734d into master Aug 11, 2021
@jadwahab jadwahab deleted the change_fee_calc branch August 11, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants