Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: EstimateIsFeePaidEnough #44

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Conversation

tigh-latte
Copy link
Contributor

Calculate if fee's have been paid, base on an estimation of what the tx's signed inputs will be.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #44 (578c81f) into master (7a05422) will decrease coverage by 0.00%.
The diff coverage is 69.23%.

❗ Current head 578c81f differs from pull request most recent head e60a76f. Consider uploading reports for the commit e60a76f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   86.05%   86.04%   -0.01%     
==========================================
  Files          26       26              
  Lines        2804     2817      +13     
==========================================
+ Hits         2413     2424      +11     
- Misses        269      270       +1     
- Partials      122      123       +1     
Impacted Files Coverage Δ
tx.go 79.41% <69.23%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a05422...e60a76f. Read the comment docs.

@mergify mergify bot added the feature label Sep 15, 2021
@jadwahab
Copy link
Member

@Tigh-Gherr what is this function for? like who would use it and where?

Copy link
Contributor

@theflyingcodr theflyingcodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 6e0ed1a into master Sep 15, 2021
@mergify mergify bot deleted the feat/estimate-is-fee-paid branch September 15, 2021 14:40
@tigh-latte
Copy link
Contributor Author

tigh-latte commented Sep 15, 2021

@jadwahab if a user of go-bt would like to see if their tx has enough inputs to cover fees + change before signing, to save signing, checking, adding, and re-signing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants