Adding NewTxFromReader to handle large blocks #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadwahab
approved these changes
Sep 27, 2021
jadwahab
requested changes
Sep 27, 2021
tx_test.go
Outdated
| r := bufio.NewReader(f) | ||
|
|
||
| header := make([]byte, 80) | ||
| if n, err := io.ReadFull(f, header); n != 80 || err != nil { |
There was a problem hiding this comment.
@ordishs can you change this to:
var n int
if n, err = io.ReadFull(f, header); n != 80 || err != nil {
because when running make test-ci it's causing the linter to fail here:
tx_test.go:175:8: shadow: declaration of "err" shadows declaration at line 163 (govet)
if n, err := io.ReadFull(f, header); n != 80 || err != nil {
^
jadwahab
approved these changes
Sep 27, 2021
jadwahab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also changed the original NewTxFromBytes() etc to wrap the byte slices with an bytes.NewReader() to be DRY'er.