Enhancement: Named err on tx not fully funded #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigh-latte
requested review from
theflyingcodr and
jadwahab
and removed request for
theflyingcodr
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 28 28
Lines 3011 3011
=======================================
Hits 2552 2552
Misses 325 325
Partials 134 134
Continue to review full report at Codecov.
|
jadwahab
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to differentiate between not enough funds, vs a system error, from the error returned from tx.Fund without doing a raw string comparison 🤮 .
Adding in a new error and updated docs.