Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Max Number Length after Genesis #78

Merged
merged 1 commit into from
Nov 4, 2021
Merged

Conversation

tigh-latte
Copy link
Contributor

The max num length is 750kb after genesis, however in our interpreter it is currently set at 4.

Moving it to the genesis config lib.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021

Codecov Report

Merging #78 (c3b35db) into master (0cd048b) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   84.99%   85.02%   +0.03%     
==========================================
  Files          30       30              
  Lines        3052     3059       +7     
==========================================
+ Hits         2594     2601       +7     
  Misses        318      318              
  Partials      140      140              
Impacted Files Coverage Δ
bscript/interpreter/scriptnum.go 100.00% <ø> (ø)
bscript/interpreter/config.go 100.00% <100.00%> (ø)
bscript/interpreter/operations.go 96.16% <100.00%> (ø)
bscript/interpreter/stack.go 94.03% <100.00%> (+0.16%) ⬆️
bscript/interpreter/thread.go 93.48% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cd048b...c3b35db. Read the comment docs.

@jadwahab jadwahab merged commit ea790cc into master Nov 4, 2021
@jadwahab jadwahab deleted the fix/genesis-num-length branch November 4, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants