Fix: Binary Maths #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 30, 2021 13:39
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 83.94% 84.53% +0.58%
==========================================
Files 35 35
Lines 3370 3504 +134
==========================================
+ Hits 2829 2962 +133
- Misses 394 395 +1
Partials 147 147
Continue to review full report at Codecov.
|
jadwahab
reviewed
Nov 16, 2021
| // interpreting it as an integer, it provides the required behaviour. | ||
| type scriptNumber struct { | ||
| val *big.Int | ||
| afterGenesis bool |
There was a problem hiding this comment.
is it only utxos which are after genesis that are treated this way?
There was a problem hiding this comment.
Nah every utxo, tho the ones before genesis are capped within the limits of pre-genesis
| @@ -241,6 +241,7 @@ func (t *thread) CheckErrorCondition(finalScript bool) error { | |||
| if finalScript { | |||
| t.afterSuccess() | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is my fav change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, arithmeitc that overflows
math.MaxInt64and underflowsmath.MinInt64just causes integer overflows within the script, meaning maths that should be compatible with large numbers just does not work on our interpreter.Also,
OP_NUM2BINandOP_BIN2NUMare implemented incorrectly.To fix this, I've fixed the implementations of the two aforementioned opcodes, and changed the
scriptNumdata type to wrapbig.Int, implementing the correct math functions and byte conversion both to and from consensus, to and from standard big endian.