Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Append Opcodes #89

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Conversation

tigh-latte
Copy link
Contributor

Change AppendOpcode to a variadic function, and have it errors when OpPUSH's are attempted to be appended.

@mergify mergify bot added the enhancement New feature or request label Dec 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #89 (4c096dc) into master (792a281) will decrease coverage by 0.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   84.51%   84.49%   -0.02%     
==========================================
  Files          35       35              
  Lines        3512     3509       -3     
==========================================
- Hits         2968     2965       -3     
  Misses        396      396              
  Partials      148      148              
Impacted Files Coverage Δ
txoutput.go 81.73% <80.00%> (-0.77%) ⬇️
bscript/script.go 60.78% <100.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792a281...4c096dc. Read the comment docs.

Copy link
Contributor

@theflyingcodr theflyingcodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change

@mergify mergify bot merged commit 83b0701 into master Dec 2, 2021
@mergify mergify bot deleted the enhancement/append-opcode-variadic branch December 2, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants