-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: ReadFrom for bt.Txs #93
Conversation
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 83.77% 83.69% -0.08%
==========================================
Files 35 35
Lines 3624 3656 +32
==========================================
+ Hits 3036 3060 +24
- Misses 424 428 +4
- Partials 164 168 +4
Continue to review full report at Codecov.
|
// Create buffered reader for this file. | ||
r := bufio.NewReader(f) | ||
|
||
// Read file header. This is step is specific to file reading and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added
ReadFrom
to thebt.Txs
type, along with an example on how to use, to further abstract the chunking of a binary block.This way users don't need to worry about the varint or tracking their progression through a byte stream.