Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for new windows import/export macro handling #520

Closed
wants to merge 2 commits into from
Closed

Suggestion for new windows import/export macro handling #520

wants to merge 2 commits into from

Conversation

OgreTransporter
Copy link

@Youw
Copy link
Member

Youw commented Mar 27, 2023

I understand this is a "step into a right direction", but what does it fix here?
The fact that you need to modify the Makefiles and MSVC project - means the changes breaks the build for those who desided to embedde HIDAPI directly as a source (as was originally advertized by the HIDAPI author) - sample.
It is not a big deal to fix it, e.g. for cython-hidapi, but that is exactly a maintenance burden I'd like to avoid completely until v1.0.

@OgreTransporter
Copy link
Author

OgreTransporter commented Mar 27, 2023 •
edited
Loading

I'd like to avoid completely until v1.0

Ok, I can understand that.

@mcuee mcuee added build system/CI Anything related to building the project or running on CI Windows Related to Windows backend CMake Related to CMake build system labels Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build system/CI Anything related to building the project or running on CI CMake Related to CMake build system Windows Related to Windows backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OgreTransporter @Youw @mcuee