Define a couple of declarations as opaque #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes the warnings mentioned in #47 (comment). I'm able to compile with $ CFLAGS="-Werror" CC=clang pip3 install . -v --break-system-packages
[...]
clang -shared -Werror build/temp.linux-x86_64-cpython-312/build/temp.linux-x86_64-cpython-312/_libvips.o -L/usr/lib64 -lvips -lgio-2.0 -lgobject-2.0 -lglib-2.0 -o build/lib.linux-x86_64-cpython-312/_libvips.abi3.so
installing to build/bdist.linux-x86_64/wheel
[...]
Successfully built pyvips
Installing collected packages: pyvips
Successfully installed pyvips-2.2.3
$ python -c "import pyvips; import _libvips; assert _libvips.lib.vips_version(0) == 8; print(pyvips.API_mode)"
TrueAny testing on macOS would be very helpful. |
|
I confirm this works on my macOS 14.4.1! |
jcupitt
reviewed
Apr 28, 2024
| } VipsProgress; | ||
|
|
||
| typedef struct _VipsObject { | ||
| ''' | ||
| typedef ... VipsObject; |
There was a problem hiding this comment.
I had no idea ... worked for typedefs as well as defines! Nice.
|
I made v2.2.3 including this fix, thank you Kleis. I'll try to look again at your nice setuptools replacement for a v3 pyvips. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #459.