Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported descriptor file encodings GBK and Big5 #10

Open
SuperGod opened this issue Sep 5, 2016 · 6 comments
Open

Unsupported descriptor file encodings GBK and Big5 #10

SuperGod opened this issue Sep 5, 2016 · 6 comments
Assignees

Comments

@SuperGod
Copy link

SuperGod commented Sep 5, 2016

The vmdk file header is like:

image

I debug the libvmdk,and find the error is happen at line 977 in libvmdk\libvmdk_descriptor_file.c

                else if( libclocale_codepage_copy_from_string(
                          &( descriptor_file->encoding ),
                          value,
                          value_length,
                          LIBCLOCALE_CODEPAGE_FEATURE_FLAG_HAVE_WINDOWS,
                          error ) != 1 )
                {
                    libcerror_error_set(
                     error,
                     LIBCERROR_ERROR_DOMAIN_RUNTIME,
                     LIBCERROR_RUNTIME_ERROR_GET_FAILED,
                     "%s: unable to determine codepage value from string.",
                     function );

                    goto on_error;
                }

so maybe libclocale_codepage_copy_from_string not support code page string like "GBK"?

@joachimmetz
Copy link
Member

That could be correct, this part of VMDK was undocumented last time I checked. I'll have a look to add GBK support when time permits.

@sinmygit
Copy link

I have got the save problem,and the vmdk coding is 'GBK' and 'Big5'

@joachimmetz joachimmetz changed the title libvmdk_handle_open failed on Windows Unsupported codepage GBK Nov 5, 2016
@joachimmetz joachimmetz self-assigned this Nov 5, 2016
@joachimmetz joachimmetz changed the title Unsupported codepage GBK Unsupported codepage GBK and Big5 Nov 5, 2016
@joachimmetz joachimmetz changed the title Unsupported codepage GBK and Big5 Unsupported descriptor file encodings GBK and Big5 Nov 5, 2016
@joachimmetz
Copy link
Member

joachimmetz commented Mar 19, 2019

GBK support which is presumed to map to Windows cp936 for now added in a3f6142

@joachimmetz
Copy link
Member

"Big5" also seems to be a broader standard like GBK but I'll map this to windows cp950 for now

https://en.wikipedia.org/wiki/Big5
https://en.wikipedia.org/wiki/GBK_(character_encoding)

@joachimmetz
Copy link
Member

Big5 support which is presumed to map to Windows cp950 for now added in 4b09bb8

@joachimmetz
Copy link
Member

based on libyal/libclocale#5, one thing that could be useful is to create a VMDK with an "euro sign" that can be shared. That should give more resolution on which encoding is actually used for GBK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants