Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported descriptor file encoding Shift_JIS #23

Closed
mnrkbys opened this issue Mar 6, 2020 · 3 comments
Closed

Unsupported descriptor file encoding Shift_JIS #23

mnrkbys opened this issue Mar 6, 2020 · 3 comments
Assignees

Comments

@mnrkbys
Copy link

mnrkbys commented Mar 6, 2020

I have encountered a problem which is similar to the libvmdk issue #10 .
VMware Workstation on Windows Japanese edition sets "encoding" to "Shift_JIS" in "Disk Descriptor" of VMDK. But libvmdk and libclocale don't support it.
Could you support Shift_JIS as same as GBK and Big5?
By the way, Shift_JIS is mapped to cp932.

libvmdk_not_support_shift_jis_00

@joachimmetz joachimmetz self-assigned this Mar 6, 2020
@joachimmetz
Copy link
Member

joachimmetz commented Mar 6, 2020

@mnrkbys, thx for the report.

Could you support Shift_JIS as same as GBK and Big5?

I can. I'll update documentation and source as soon as time permits.

Are you aware of any edge cases where Shift_JIS would be (potentially) different from cp932?

In the mean time if you extend libvmdk/libvmdk_descriptor_file.c similar to 4b09bb8 that should get you the functionality you need

@mnrkbys
Copy link
Author

mnrkbys commented Mar 8, 2020

Sorry, I am not familiar with character codes.
So, I don't know what is the difference between Shift_JIS and cp932.
I will try to make the patch. Thank you.

@joachimmetz
Copy link
Member

Changes in 2094cdb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants