Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure chat loses focus on board click #5323

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Ensure chat loses focus on board click #5323

merged 1 commit into from
Jul 30, 2019

Conversation

isaacl
Copy link
Member

@isaacl isaacl commented Jul 14, 2019

@isaacl isaacl requested a review from niklasf July 14, 2019 12:50
@isaacl
Copy link
Member Author

isaacl commented Jul 14, 2019

hopefully temporary hack. We might be able to restore more normal click behavior with PointerEvents (see lichess-org/chessground#110)

@isaacl
Copy link
Member Author

isaacl commented Jul 14, 2019

I need help testing this before landing

@ornicar
Copy link
Collaborator

ornicar commented Jul 15, 2019

Maybe only set the listeners while chat input is focused?

@isaacl
Copy link
Member Author

isaacl commented Jul 30, 2019

please take another look!

@ornicar ornicar merged commit 7a5f3ab into lichess-org:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasf niklasf Awaiting requested review from niklasf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaacl @ornicar