Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-cookies, no-cache-validate channels for /ipfs/ paths? #72

Closed
the8472 opened this issue Feb 11, 2016 · 3 comments
Closed

no-cookies, no-cache-validate channels for /ipfs/ paths? #72

the8472 opened this issue Feb 11, 2016 · 3 comments
Labels
help wanted Seeking public contribution on this issue kind/discussion Topical discussion; usually not changes to codebase

Comments

@the8472
Copy link
Contributor

the8472 commented Feb 11, 2016

As noted in 4296e7d setting nsIRequest.LOAD_ANONYMOUS and VALIDATE_NEVER on requests to gateways might make sense.

Cookies set while explicitly browsing http://gateway.tld/foo/bar pages shouldn't have anything to do with the gateway services themselves, and there's no meaningful way to expose them to content anyway.
And /ipfs/ paths should be forever stable, so we can be pretty sure that they don't need any cache validation, no matter what the server says.

@lidel lidel added the kind/discussion Topical discussion; usually not changes to codebase label Feb 11, 2016
@lidel
Copy link
Member

lidel commented Feb 11, 2016

  • I agree on nsIRequest.VALIDATE_NEVER for /ipfs/, it would not hurt to set it.
  • nsIRequest.LOAD_ANONYMOUS: I am bit worried that blocking cookies may cause some unknown consequences, eg. break some static apps that use them for simple things like storing theme/font size preference, game saves etc.
    Question: does it also block localStorage?

@Kubuxu
Copy link
Member

Kubuxu commented Feb 11, 2016

localStorage is disabled where there is no authority part in URI.

@lidel
Copy link
Member

lidel commented Feb 11, 2016

After giving it some thought I think would be ok to enable nsIRequest.LOAD_ANONYMOUS when fs: is set as a target protocol handler (#70).
Even if we set fs: as a default, there will be an option to disable it and fallback to http-based URLs, in which cookies and localStorage work in old school way.

This should be good enough for now, at least until we have #71 sorted out.

@lidel lidel added the help wanted Seeking public contribution on this issue label Feb 12, 2016
@lidel lidel closed this as completed in c75a05d Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/discussion Topical discussion; usually not changes to codebase
Projects
None yet
Development

No branches or pull requests

3 participants