Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta-parm for not being under fs:/ #88

Closed
Kubuxu opened this issue Feb 22, 2016 · 6 comments
Closed

meta-parm for not being under fs:/ #88

Kubuxu opened this issue Feb 22, 2016 · 6 comments
Labels
kind/discussion Topical discussion; usually not changes to codebase

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Feb 22, 2016

It breaks for example anuglar.js.

Example: access fs:/ipns/glowing-bear.ipfs.ovh
It might redirect to http already but it is other bug.

@the8472
Copy link
Contributor

the8472 commented Feb 23, 2016

Analyzing what causes this issue and whether it may be fixed should be a saner approach than simply disabling the feature.

@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 23, 2016

It is but getting things to work with it will be a really long process.

@lidel lidel added the kind/discussion Topical discussion; usually not changes to codebase label Feb 24, 2016
@the8472
Copy link
Contributor

the8472 commented Feb 28, 2016

Well, i'm interested in what fails, but the source is minified and auto-prettify doesn't seem to work. Can you try it without minified code?

lidel added a commit that referenced this issue Mar 5, 2016
@lidel
Copy link
Member

lidel commented Mar 5, 2016

I think we should fix underlying issue: adding custom HTML hints which are only used by one browser sounds like an nightmare from IE 6 times 😢

As for the problem at hand, glowing-bear.ipfs.ovh does not work any more, but my intuition is that the problem is caused either by fs:→https: redirect or no-cookies for /ipfs/ paths.

Until fixed, there is a note about fs: breaking JavaScript on some pages (cf8bbc4).

@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 6, 2016

Sorry for glowing-bear.ipfs.ovh not working but my IPFS suffer hangs so I can't run it. It will come back when underlying issue is solved.

@lidel
Copy link
Member

lidel commented Oct 15, 2017

Now that we closed #20 this is no longer reproducible: we don't have custom protocol anymore, only a set of hacks that redirect to HTTP -- see #164 for more details.

I am closing this one.
If similar problem surfaces again, it should be a new issue (for webextension version).

@lidel lidel closed this as completed Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Topical discussion; usually not changes to codebase
Projects
None yet
Development

No branches or pull requests

3 participants