Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stake Form refactor #102

Merged
merged 31 commits into from
Dec 11, 2023
Merged

Stake Form refactor #102

merged 31 commits into from
Dec 11, 2023

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Oct 19, 2023 •
edited
Loading

Description

  • refactored stake form to use hook form
  • added proper error for invalid referral
  • hover tooltip for stakeable ether in wallet card
  • submit -> stake text on button
  • fixed up css in footer
  • cleaned up deprecated/unused code
  • every tx price in fiat now uses same component that shows tooltip if cost is less than 0.01
  • add token to wallet for steth on claim page

Demo

image

Code review notes

  • home -> stake rename
  • feature slice for stake
  • used old modal same as in wrap
  • organised and merged some folders ( layout folder now contains header and footer)

Testing notes

  • needs full check for stake incld, stake limit, refferal and others
  • minor check for wrap/unwrap because I tweaked some common code

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners October 19, 2023 09:50
@preview-stands
Copy link

preview-stands bot commented Oct 19, 2023 •
edited
Loading

Preview stand status

Stand was demolished

manneredboor
manneredboor previously approved these changes Nov 15, 2023
View reviewed changes
@Jeday
Merge branch 'develop' of github.com:lidofinance/ethereum-staking-wid…
e4d1f4d 
…get into feature/si-583-stake-widget-stake-page-form-refactor
DiRaiks
DiRaiks previously approved these changes Dec 4, 2023
View reviewed changes
solidovic
solidovic previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@solidovic solidovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. there are optional suggests

Tarens2
Tarens2 previously approved these changes Dec 8, 2023
View reviewed changes
solidovic
solidovic previously approved these changes Dec 8, 2023
View reviewed changes
@Jeday Jeday dismissed stale reviews from solidovic and Tarens2 via acd2ce6 December 11, 2023 10:23
@Jeday
Merge branch 'develop' of github.com:lidofinance/ethereum-staking-wid…
1653918 
…get into feature/si-583-stake-widget-stake-page-form-refactor
@Jeday
fix: remove invalid disabled state
850eb46
@Jeday
Merge branch 'develop' of github.com:lidofinance/ethereum-staking-wid…
f22702c 
…get into feature/si-583-stake-widget-stake-page-form-refactor
@itaven itaven merged commit a83a5ea into develop Dec 11, 2023
8 checks passed
@itaven itaven deleted the feature/si-583-stake-widget-stake-page-form-refactor branch December 11, 2023 22:10
@itaven itaven mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiRaiks DiRaiks DiRaiks approved these changes

@solidovic solidovic solidovic approved these changes

@Tarens2 Tarens2 Tarens2 left review comments

@manneredboor manneredboor Awaiting requested review from manneredboor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jeday @manneredboor @solidovic @Tarens2 @DiRaiks @itaven