Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ipfs links #174

Merged
merged 11 commits into from
Dec 12, 2023
Merged

fix: ipfs links #174

merged 11 commits into from
Dec 12, 2023

Conversation

solidovic
Copy link
Contributor

@solidovic solidovic commented Dec 7, 2023 •
edited
Loading

Description

  • Fix the opening in new tab (IPFS version)
  • Fix for withdrawals/claim is active nav link (IPFS version)
  • Fix scroll to top (IPFS version)
  • Fix(reward page): clipboard button (IPFS version)

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@solidovic solidovic requested review from a team as code owners December 7, 2023 10:06
@preview-stands
Copy link

preview-stands bot commented Dec 7, 2023 •
edited
Loading

Preview stand status

Stand was demolished

Tarens2
Tarens2 previously approved these changes Dec 7, 2023
View reviewed changes
@solidovic solidovic changed the title fix: opening in new tab (IPFS links) fix: ipfs links Dec 8, 2023
DiRaiks
DiRaiks previously approved these changes Dec 11, 2023
View reviewed changes
Jeday
Jeday requested changes Dec 11, 2023
View reviewed changes
shared/components/link-ipfs.tsx Outdated Show resolved Hide resolved
shared/components/link-ipfs.tsx Outdated Show resolved Hide resolved
shared/components/link-ipfs.tsx Outdated Show resolved Hide resolved
@solidovic solidovic requested a review from Jeday December 11, 2023 14:38
Jeday
Jeday previously approved these changes Dec 11, 2023
View reviewed changes
@solidovic solidovic requested a review from Jeday December 12, 2023 07:32
@itaven itaven merged commit ec9709e into develop Dec 12, 2023
6 checks passed
@itaven itaven deleted the feature/si-1111-fix-links-in-ipfs-when-open-in-new-tab branch December 12, 2023 07:54
@itaven itaven mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeday Jeday Jeday approved these changes

@Tarens2 Tarens2 Awaiting requested review from Tarens2

@DiRaiks DiRaiks Awaiting requested review from DiRaiks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@solidovic @Jeday @Tarens2 @DiRaiks @itaven