-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lido pushBeacon with _beaconValidators amount for proper reward calculation #128
Comments
ongrid
added a commit
that referenced
this issue
Nov 12, 2020
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() #71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance #71 Related: #110
ongrid
added a commit
that referenced
this issue
Nov 14, 2020
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() #71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance #71 * Rename totalControlledEther to totalPooledEther * Rename getEther2Stat getBeaconStat Related: #110
lxzrv
pushed a commit
that referenced
this issue
Nov 17, 2020
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() #71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance #71 * Rename totalControlledEther to totalPooledEther * Rename getEther2Stat getBeaconStat Related: #110
ongrid
added a commit
that referenced
this issue
Nov 17, 2020
ongrid
added a commit
that referenced
this issue
Nov 17, 2020
ongrid
added a commit
that referenced
this issue
Nov 18, 2020
ongrid
added a commit
that referenced
this issue
Nov 22, 2020
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() #71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance #71 * Rename totalControlledEther to totalPooledEther * Rename getEther2Stat getBeaconStat Related: #110
ongrid
added a commit
that referenced
this issue
Nov 22, 2020
ongrid
added a commit
that referenced
this issue
Nov 22, 2020
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() #71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance #71 * Rename totalControlledEther to totalPooledEther * Rename getEther2Stat getBeaconStat Related: #110
ongrid
added a commit
that referenced
this issue
Nov 22, 2020
skozin
pushed a commit
that referenced
this issue
Nov 22, 2020
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() #71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance #71 * Rename totalControlledEther to totalPooledEther * Rename getEther2Stat getBeaconStat Related: #110
skozin
pushed a commit
that referenced
this issue
Nov 22, 2020
krogla
pushed a commit
that referenced
this issue
Jan 26, 2021
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() #71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance #71 * Rename totalControlledEther to totalPooledEther * Rename getEther2Stat getBeaconStat Related: #110
krogla
pushed a commit
that referenced
this issue
Jan 26, 2021
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this issue
Jan 26, 2021
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() lidofinance#71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance lidofinance#71 * Rename totalControlledEther to totalPooledEther * Rename getEther2Stat getBeaconStat Related: lidofinance#110
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this issue
Jan 26, 2021
* Add PushableMock contract * Add pushBeacon unittests Related: lidofinance#110, #4
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this issue
Jan 26, 2021
* Improve PushableMock contract * Extend pushBeacon unittests Related: lidofinance#110, #4
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this issue
Jan 26, 2021
Extend pushBeacon unittests to cover different cases/combinations of depositedValidators/beaconValidators/beaconBalances Related: lidofinance#110, #4
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this issue
Jan 26, 2021
tamtamchik
pushed a commit
that referenced
this issue
Sep 30, 2024
….0.0 chore(deps): bump setuptools from 69.5.1 to 70.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To implement the new reward algorithm proposed in LIP-3, existing
reportEther2
method needs to be re-implemented:function pushBeacon(uint128 _beaconValidators, uint256 _beaconBalance) external...
now receives the number of validators in beacon validator setgetInProcessBalance()
method that eturns the total base balance (multiple of 32) of validators in transient state. The value nominated in wei (1e-18 Ether)rewardBase
calculation principles to be changed). RewardBase will be calculated dynamically and not stored. Instead of this, Lido stores previously pushed beaconBalance -lastBeaconBalance
.Eth2
andremote
renamed to beacon to unify within codebase._getTotalControlledEther()
will be renamed togetTotalPooledEth()
Tests:
Solves functional: #110, #4 and cosmetic: #87, #71
The text was updated successfully, but these errors were encountered: