Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oracle contract #16

Merged
merged 7 commits into from
Sep 23, 2020
Merged

Oracle contract #16

merged 7 commits into from
Sep 23, 2020

Conversation

lxzrv
Copy link
Contributor

@lxzrv lxzrv commented Sep 21, 2020 •
edited
Loading

  • Update oracle smart contract to fix corresponding issues
  • Add new aggregated data processing with efficient mode finding, described here

@lxzrv lxzrv added the enhancement New feature or request label Sep 21, 2020
@lxzrv lxzrv requested a review from Eenae September 21, 2020 08:50
@lxzrv lxzrv requested review from vshvsh and removed request for Eenae September 21, 2020 14:10
@vshvsh
Copy link
Contributor

vshvsh commented Sep 22, 2020

Should be a test case for reporting an interval that is > last finalized and < current (e.g. if las finalized is 1000 and current is 1005, test for reporting 1003)

@vshvsh vshvsh requested review from Eenae and removed request for vshvsh September 22, 2020 04:14
@lxzrv
Copy link
Contributor Author

lxzrv commented Sep 22, 2020 •
edited
Loading

Should be a test case for reporting an interval that is > last finalized and < current (e.g. if las finalized is 1000 and current is 1005, test for reporting 1003)

The last test cases were relevant, tweaked them a little more.

Eenae
Eenae suggested changes Sep 22, 2020
View reviewed changes
apps/depooloracle/contracts/Algorithm.sol Show resolved Hide resolved
apps/depooloracle/contracts/DePoolOracle.sol Outdated Show resolved Hide resolved
apps/depooloracle/contracts/DePoolOracle.sol Show resolved Hide resolved
@lxzrv lxzrv requested a review from Eenae September 23, 2020 07:37
@lxzrv lxzrv merged commit eced0a7 into master Sep 23, 2020
@lxzrv lxzrv deleted the oracle_contract branch September 23, 2020 13:21
dechjo pushed a commit to dechjo/lido-dao that referenced this pull request Jan 26, 2021
Merge pull request lidofinance#16 from depools/oracle_contract
7e6e7ad 
Oracle contract improvements
@dechjo dechjo mentioned this pull request Apr 5, 2021
Merged
tamtamchik pushed a commit that referenced this pull request Sep 30, 2024
@mymphe
Merge pull request #16 from lidofinance/develop
146713a 
Weekly master push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vshvsh vshvsh vshvsh approved these changes

@Eenae Eenae Eenae approved these changes

Assignees

@Eenae Eenae

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lxzrv @vshvsh @Eenae