Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in our code originated in the
liesel.goose.optim
module, specifically in the callback that updates the progress bar.In the callback, the current loss values were accessed like this:
Some experimentation revealed that this pattern was the problem. Introducing dedicated
"current_loss_train"
and"current_loss_validation"
carry values solved the issue:While I was at it, I fixed two other issues with the progress bar:
progress_bar=False
from taking effect, i.e. the progress bar couldn't be turned off. This is fixed now.max_iter-1
as the total number of iterations. This is fixed now.