Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add central type for base options of a handler #65

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

swain
Copy link
Contributor

@swain swain commented Nov 29, 2023

Motivation

Centralizing this type for a little DRY up.

Base automatically changed from node-18 to master November 29, 2023 16:41
@swain swain marked this pull request as ready for review November 29, 2023 16:42
* The `object` parameter is an _already unmarshalled_ version of the Dynamo
* record.
*/
parse: (object: unknown) => Entity;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: we used the Message and Event suffix for SQS and Kinesis, so Image would make sense here.

@swain swain merged commit 2f46b52 into master Nov 29, 2023
2 checks passed
@swain swain deleted the base-options branch November 29, 2023 16:53
Copy link

🎉 This PR is included in version 5.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants