Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reference correct logger #74

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: reference correct logger #74

merged 1 commit into from
Apr 29, 2024

Conversation

swain
Copy link
Contributor

@swain swain commented Apr 29, 2024

Motivation

A bad reference slipped in a few months ago here. It was causing the correlationId and request id to be lost from the record-specific logger.

epeters3
epeters3 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@epeters3 epeters3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swain swain merged commit 4c9edbe into master Apr 29, 2024
4 checks passed
@swain swain deleted the fix-logger branch April 29, 2024 15:26
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.5.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epeters3 epeters3 epeters3 approved these changes

@aecorredor aecorredor aecorredor approved these changes

@mdlavin mdlavin mdlavin approved these changes

@nicolls1 nicolls1 Awaiting requested review from nicolls1

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swain @mdlavin @aecorredor @epeters3