Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add equals as a range key condition #21

Merged
merged 1 commit into from
Apr 1, 2024
Merged

feat: Add equals as a range key condition #21

merged 1 commit into from
Apr 1, 2024

Conversation

aymanenadi
Copy link
Contributor

No description provided.

aecorredor
aecorredor approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@aecorredor aecorredor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a unit test that needs updating after this? Or are there no validation around the supported range key conditions?

@aymanenadi
Copy link
Contributor Author

Isn't there a unit test that needs updating after this? Or are there no validation around the supported range key conditions?

It doesn't look like that is tested. Serialization is what's tested.

@aymanenadi aymanenadi merged commit 50d6455 into master Apr 1, 2024
4 checks passed
@aymanenadi aymanenadi deleted the feat--add-equals-as-a-range-key-condition branch April 1, 2024 16:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Apr 1, 2024
@aymanenadi aymanenadi restored the feat--add-equals-as-a-range-key-condition branch April 1, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aecorredor aecorredor aecorredor approved these changes

@SchaeStewart SchaeStewart Awaiting requested review from SchaeStewart

@swain swain Awaiting requested review from swain

@jkdowdle jkdowdle Awaiting requested review from jkdowdle

@rob-snyder rob-snyder Awaiting requested review from rob-snyder

Assignees
No one assigned
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanenadi @aecorredor