feat: allow updating cache entries using a predicate function #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swain
force-pushed
the
cache-update-predicate
branch
from
4b99c20 to
bf00472
Compare
swain
requested review from
sternetj,
aecorredor,
SchaeStewart,
aymanenadi,
jkdowdle and
epeters3
jkdowdle
approved these changes
Dec 11, 2024
aecorredor
reviewed
Dec 11, 2024
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
aecorredor
approved these changes
Dec 11, 2024
| /* istanbul ignore next */ | ||
| return false; | ||
| } | ||
| const payloadInKey = keyPrefix ? queryKey[1] : queryKey[0]; |
There was a problem hiding this comment.
The code was a little harder to follow now - maybe a good doc comment above the line 51 would help parse this a bit quicker.
| keyPrefix, | ||
| createQueryKey(name, route, payloadOrPredicate), | ||
| ].filter(Boolean), | ||
| exact: true, |
There was a problem hiding this comment.
Why did we need exact now, when we didn't have it before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'd like to be able to provide a predicate for updating cache entries, to allow updating all cache entries for an endpoint that match a particular pattern.