Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skipLibCheck: true #23

Merged
merged 1 commit into from
Oct 17, 2023
Merged

feat: add skipLibCheck: true #23

merged 1 commit into from
Oct 17, 2023

Conversation

swain
Copy link
Contributor

@swain swain commented Oct 17, 2023

Motivation

It's extremely common for folks to add skipLibCheck: true to tsconfigs. When a library is shipping bogus .d.ts files, adding skipLibCheck: true is almost always the right move.

@swain swain requested review from shawnzhu and epeters3 October 17, 2023 17:48
shawnzhu
shawnzhu approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@shawnzhu shawnzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@swain swain merged commit 90768d7 into master Oct 17, 2023
3 checks passed
@swain swain deleted the skip-lib-check branch October 17, 2023 20:18
@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnzhu shawnzhu shawnzhu approved these changes

@epeters3 epeters3 Awaiting requested review from epeters3

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swain @shawnzhu