Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] LPS-121363 #400

Closed
wants to merge 1 commit into from
Closed

Conversation

ChrisKian
Copy link

https://issues.liferay.com/browse/LPS-121363

Spec: https://www.w3.org/TR/html-aria/#svg

Please let me know if you have any questions, thanks!

…ems to be the best fit, since we are displaying icons.
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@pat270
Copy link

pat270 commented Sep 23, 2020

I went down a rabbit hole trying to find an answer to this. We had a huge discussion about this in the past, if you want to check it out.

liferay/clay#1242
liferay/clay#1296
liferay/clay#1324

I think https://validator.w3.org/nu/#textarea is only checking the html-aria spec which only allows roles application, document, and img, but svg-aam says we can use any role. IMO is this is an edge case and we should ignore the error message.

The icons for the alerts, buttons and possibly all icons in Portal are purely decorational. They shouldn't be read out to screen readers.

References:

Spec Rule
html-aria SVG Roles: application, document or img. Global aria-* attributes and any aria-* attributes applicable to the allowed roles and implied role (if any).
svg-aam-1.0 Default Platform WAI-ARIA Role Mappings graphics-document. Allowed WAI-ARIA Roles and Platform WAI-ARIA Role Mappings any role; see the Core Accessibility API Role Mappings and the Graphics Accessibility API Role Mappings

/cc @marcoscv-work @jbalsas

@ChrisKian
Copy link
Author

Thank you @pat270, if this is the official answer, we can close this PR out. Thanks!

@jbalsas
Copy link

jbalsas commented Sep 28, 2020

Thanks @ChrisKian, closing! Feel free to reopen or continue the conversation if there's anything else you'd like to discuss!

@jbalsas jbalsas closed this Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants