Skip to content

Commit

Permalink
Merge pull request #693 from carloslancha/issue-684-management-post-form
Browse files Browse the repository at this point in the history 
Management Toolbar search form need method POST | Fixes #684
  • Loading branch information
@matuzalemsteles
matuzalemsteles authored Mar 5, 2018
2 parents ba81292 + 791bde1 commit 51a7fc5
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 33 deletions.
18 changes: 9 additions & 9 deletions packages/clay-dataset-display/src/__tests__/__snapshots__/ClayDatasetDisplay.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay and change view o
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -734,7 +734,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay and change view o
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -1423,7 +1423,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay and change view o
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -2290,7 +2290,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay with grouped item
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -2821,7 +2821,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay with items and li
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -3680,7 +3680,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay with items and li
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -4677,7 +4677,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay with items and li
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -5366,7 +5366,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay with items and se
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down Expand Up @@ -6553,7 +6553,7 @@ exports[`ClayDatasetDisplay should render a ClayDatasetDisplay with ungrouped it
</ul>
<div class="navbar-form navbar-form-autofit navbar-overlay navbar-overlay-sm-down">
<div class="container-fluid container-fluid-max-xl">
<form action="mySearchURL" name="mySearchName" role="search">
<form action="mySearchURL" method="POST" name="mySearchName" role="search">
<div class="input-group">
<div class="input-group-item">
<input aria-label="Search" class="form-control input-group-inset input-group-inset-after" name="mySearchInputName" placeholder="Search for..." ref="search" type="text">
Expand Down
1 change: 1 addition & 0 deletions packages/clay-management-toolbar/src/ClayManagementToolbar.soy
View file
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,7 @@
action="{$searchActionURL}"
{/if}

method="POST"
{if $searchFormName}
name="{$searchFormName}"
{/if}
Expand Down
Loading

0 comments on commit 51a7fc5

Please sign in to comment.