Merge pull request #580 from carloslancha/TestFixes

Stub console.error | Fixes #579
liferay · Feb 20, 2018 · dbee0bc · dbee0bc
2 parents fc3d60f + 7075fcb
commit dbee0bc
Show file tree

Hide file tree

Showing 15 changed files with 255 additions and 27 deletions.
diff --git a/packages/clay-alert/src/__tests__/ClayAlert.js b/packages/clay-alert/src/__tests__/ClayAlert.js
@@ -1,14 +1,27 @@
 import ClayAlert from '../ClayAlert';
 
+let consoleErrorReference;
 let alert;
-
 const spritemap = '../node_modules/clay/lib/images/icons/icons.svg';
 
+/**
+ * Stubs console.error
+ */
+function mockConsoleError() {
+	console.error = () => {};
+}
+
 describe('ClayAlert', function() {
+	beforeEach(() => {
+		consoleErrorReference = console.error;
+	});
+
 	afterEach(() => {
 		if (alert) {
 			alert.dispose();
 		}
+
+		console.error = consoleErrorReference;
 	});
 
 	it('should render default markup', function() {
@@ -128,6 +141,8 @@ describe('ClayAlert', function() {
 	});
 
 	it('should fail when no message is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			alert = new ClayAlert({
 				spritemap: spritemap,
@@ -137,6 +152,8 @@ describe('ClayAlert', function() {
 	});
 
 	it('should fail when no spritemap is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			alert = new ClayAlert({
 				message: 'message',
@@ -146,6 +163,8 @@ describe('ClayAlert', function() {
 	});
 
 	it('should fail when no title is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			alert = new ClayAlert({
 				message: 'message',

diff --git a/packages/clay-alert/src/__tests__/ClayStripe.js b/packages/clay-alert/src/__tests__/ClayStripe.js
@@ -1,14 +1,27 @@
 import ClayStripe from '../ClayStripe';
 
+let consoleErrorReference;
 let stripe;
-
 const spritemap = '../node_modules/clay/lib/images/icons/icons.svg';
 
+/**
+ * Stubs console.error
+ */
+function mockConsoleError() {
+	console.error = () => {};
+}
+
 describe('ClayStripe', function() {
+	beforeEach(() => {
+		consoleErrorReference = console.error;
+	});
+
 	afterEach(() => {
 		if (stripe) {
 			stripe.dispose();
 		}
+
+		console.error = consoleErrorReference;
 	});
 
 	it('should render default markup', function() {
@@ -150,6 +163,8 @@ describe('ClayStripe', function() {
 	});
 
 	it('should fail when no message is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			stripe = new ClayStripe({
 				spritemap: spritemap,
@@ -159,6 +174,8 @@ describe('ClayStripe', function() {
 	});
 
 	it('should fail when no spritemap is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			stripe = new ClayStripe({
 				message: 'message',
@@ -168,6 +185,8 @@ describe('ClayStripe', function() {
 	});
 
 	it('should fail when no title is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			stripe = new ClayStripe({
 				message: 'message',

diff --git a/packages/clay-alert/src/__tests__/ClayToast.js b/packages/clay-alert/src/__tests__/ClayToast.js
@@ -1,14 +1,27 @@
 import ClayToast from '../ClayToast';
 
+let consoleErrorReference;
 let toast;
-
 const spritemap = '../node_modules/clay/lib/images/icons/icons.svg';
 
+/**
+ * Stubs console.error
+ */
+function mockConsoleError() {
+	console.error = () => {};
+}
+
 describe('ClayToast', function() {
+	beforeEach(() => {
+		consoleErrorReference = console.error;
+	});
+
 	afterEach(() => {
 		if (toast) {
 			toast.dispose();
 		}
+
+		console.error = consoleErrorReference;
 	});
 
 	it('should render default markup', function() {
@@ -150,6 +163,8 @@ describe('ClayToast', function() {
 	});
 
 	it('should fail when no message is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			toast = new ClayToast({
 				spritemap: spritemap,
@@ -159,6 +174,8 @@ describe('ClayToast', function() {
 	});
 
 	it('should fail when no spritemap is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			toast = new ClayToast({
 				message: 'message',
@@ -168,6 +185,8 @@ describe('ClayToast', function() {
 	});
 
 	it('should fail when no title is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			toast = new ClayToast({
 				message: 'message',

diff --git a/packages/clay-card-grid/src/__tests__/ClayCardGrid.js b/packages/clay-card-grid/src/__tests__/ClayCardGrid.js
@@ -182,7 +182,7 @@ describe('ClayCardGrid', function() {
 	it('should render a ClayCardGrid with classes', () => {
 		component = new ClayCardGrid({
 			elementClasses: 'my-custom-class',
-			schema: [],
+			schema: {},
 		});
 
 		expect(component).toMatchSnapshot();
@@ -191,7 +191,7 @@ describe('ClayCardGrid', function() {
 	it('should render a ClayCardGrid with id', () => {
 		component = new ClayCardGrid({
 			id: 'myId',
-			schema: [],
+			schema: {},
 		});
 
 		expect(component).toMatchSnapshot();

diff --git a/packages/clay-card/src/__tests__/ClayFileCard.js b/packages/clay-card/src/__tests__/ClayFileCard.js
@@ -1,6 +1,7 @@
 import ClayFileCard from '../ClayFileCard';
 
 let component;
+let consoleErrorReference;
 let spritemap = 'icons.svg';
 let actionItems = [
 	{
@@ -13,11 +14,24 @@ let actionItems = [
 	},
 ];
 
+/**
+ * Stubs console.error
+ */
+function mockConsoleError() {
+	console.error = () => {};
+}
+
 describe('ClayFileCard', function() {
+	beforeEach(() => {
+		consoleErrorReference = console.error;
+	});
+
 	afterEach(() => {
 		if (component) {
 			component.dispose();
 		}
+
+		console.error = consoleErrorReference;
 	});
 
 	it('should render the default markup', () => {
@@ -395,6 +409,8 @@ describe('ClayFileCard', function() {
 	});
 
 	it('should fail when no spritemap is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			component = new ClayFileCard({
 				title: 'My Title',
@@ -403,6 +419,8 @@ describe('ClayFileCard', function() {
 	});
 
 	it('should fail when no title is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			component = new ClayFileCard({
 				spritemap: spritemap,

diff --git a/packages/clay-card/src/__tests__/ClayHorizontalCard.js b/packages/clay-card/src/__tests__/ClayHorizontalCard.js
@@ -1,6 +1,7 @@
 import ClayHorizontalCard from '../ClayHorizontalCard';
 
 let component;
+let consoleErrorReference;
 let spritemap = 'icons.svg';
 let actionItems = [
 	{
@@ -13,11 +14,24 @@ let actionItems = [
 	},
 ];
 
+/**
+ * Stubs console.error
+ */
+function mockConsoleError() {
+	console.error = () => {};
+}
+
 describe('ClayHorizontalCard', function() {
+	beforeEach(() => {
+		consoleErrorReference = console.error;
+	});
+
 	afterEach(() => {
 		if (component) {
 			component.dispose();
 		}
+
+		console.error = consoleErrorReference;
 	});
 
 	it('should render the default markup', () => {
@@ -149,6 +163,8 @@ describe('ClayHorizontalCard', function() {
 	});
 
 	it('should fail when no spritemap is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			component = new ClayHorizontalCard({
 				title: 'My Title',
@@ -157,6 +173,8 @@ describe('ClayHorizontalCard', function() {
 	});
 
 	it('should fail when no title is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			component = new ClayHorizontalCard({
 				spritemap: spritemap,

diff --git a/packages/clay-card/src/__tests__/ClayImageCard.js b/packages/clay-card/src/__tests__/ClayImageCard.js
@@ -1,6 +1,7 @@
 import ClayImageCard from '../ClayImageCard';
 
 let component;
+let consoleErrorReference;
 let spritemap = 'icons.svg';
 let actionItems = [
 	{
@@ -13,11 +14,24 @@ let actionItems = [
 	},
 ];
 
+/**
+ * Stubs console.error
+ */
+function mockConsoleError() {
+	console.error = () => {};
+}
+
 describe('ClayImageCard', function() {
+	beforeEach(() => {
+		consoleErrorReference = console.error;
+	});
+
 	afterEach(() => {
 		if (component) {
 			component.dispose();
 		}
+
+		console.error = consoleErrorReference;
 	});
 
 	it('should render the default markup', () => {
@@ -415,6 +429,8 @@ describe('ClayImageCard', function() {
 	});
 
 	it('should fail when no title is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			component = new ClayImageCard();
 		}).toThrow();

diff --git a/packages/clay-card/src/__tests__/ClayUserCard.js b/packages/clay-card/src/__tests__/ClayUserCard.js
@@ -1,6 +1,7 @@
 import ClayUserCard from '../ClayUserCard';
 
 let component;
+let consoleErrorReference;
 let spritemap = 'icons.svg';
 let actionItems = [
 	{
@@ -13,11 +14,24 @@ let actionItems = [
 	},
 ];
 
+/**
+ * Stubs console.error
+ */
+function mockConsoleError() {
+	console.error = () => {};
+}
+
 describe('ClayUserCard', function() {
+	beforeEach(() => {
+		consoleErrorReference = console.error;
+	});
+
 	afterEach(() => {
 		if (component) {
 			component.dispose();
 		}
+
+		console.error = consoleErrorReference;
 	});
 
 	it('should render the default markup', () => {
@@ -267,6 +281,8 @@ describe('ClayUserCard', function() {
 	});
 
 	it('should fail when no name is passed', function() {
+		mockConsoleError();
+
 		expect(() => {
 			component = new ClayUserCard();
 		}).toThrow();