Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip default position #1082

Closed
boton opened this issue Aug 14, 2018 · 3 comments
Closed

Tooltip default position #1082

boton opened this issue Aug 14, 2018 · 3 comments
Labels
status: next-release Issues that will enter into the next release type: enhancement Issues that are open to bring improvements or refinement of code

Comments

@boton
Copy link
Member

boton commented Aug 14, 2018

I find it unnatural that the tooltip's default position is Bottom.
I suggest we follow the bootstrap way of use which defaults to "Top".
boton added a commit to boton/clay that referenced this issue Aug 16, 2018
@boton
Update jest snapshots | Related liferay#1082
13e88ab
@julien julien mentioned this issue Aug 16, 2018
Merged
@julien
Copy link
Contributor

julien commented Aug 16, 2018 •
edited
Loading

Hey @victorvalle , @marcoscv and @pat270,

When you have a moment could you tell us what you think about this proposal?

Thanks!

@victorvalle
Copy link

@boton @julien Yeah default position top is better, please change it to that. Thanks for noticing it!

I've updated the documentation.

@julien
Copy link
Contributor

julien commented Aug 20, 2018

Thanks for the feedback @victorvalle !

@carloslancha carloslancha added type: enhancement Issues that are open to bring improvements or refinement of code status: next-release Issues that will enter into the next release labels Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: next-release Issues that will enter into the next release type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@julien @boton @carloslancha @victorvalle