Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant aria-label in clayButton #1174

Closed
boton opened this issue Sep 7, 2018 · 0 comments
Closed

Redundant aria-label in clayButton #1174

boton opened this issue Sep 7, 2018 · 0 comments
Labels
comp: accessibility Issues related to accessibility in general status: next-release Issues that will enter into the next release

Comments

@boton
Copy link
Member

boton commented Sep 7, 2018 •
edited
Loading

I think that setting the aria-label attribute's value according to the label param if aria-label param is blank https://github.com/liferay/clay/blob/master/packages/clay-button/src/ClayButton.soy#L52 creates duplicate information, because if a label set the content, it will be set both for aria-label and content will be read by screen readers twice.
@marcoscv-work marcoscv-work added comp: accessibility Issues related to accessibility in general Accessibility - Screen Reader labels Sep 7, 2018
@darekkay darekkay mentioned this issue Oct 7, 2018
Closed
matuzalemsteles added a commit that referenced this issue Nov 22, 2018
@matuzalemsteles
Merge pull request #1325 from liferay/pr-1224
3bf0b7b 
Fixes #1174 - Remove redundant aria-label in clayButton
@matuzalemsteles matuzalemsteles added the status: next-release Issues that will enter into the next release label Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: accessibility Issues related to accessibility in general status: next-release Issues that will enter into the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@boton @jbalsas @marcoscv-work @matuzalemsteles