Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter Label Items don't allow HTML inside #1228

Closed
4lejandrito opened this issue Oct 10, 2018 · 3 comments
Closed

Filter Label Items don't allow HTML inside #1228

4lejandrito opened this issue Oct 10, 2018 · 3 comments
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done

Comments

@4lejandrito
Copy link
Member

To be able to fully apply the designs we need to be able to add a bit of html to the labels.

At the moment we are passing name: value but we would like to pass something like name: <strong>value</strong>. If we do that the html tags are escaped and rendered as text instead of html.

Thanks!
@matuzalemsteles
Copy link
Member

hey @4lejandrito, Actually we are supporting this, this is linked to a bug in Metal metal/metal.js#381.

@4lejandrito
Copy link
Member Author

Hi @matuzalemsteles,

Thanks for your response. Does it mean that when that issue is fixed this will be fixed too? If that is the case I will keep an eye on this issue until you guys close it.

Thanks!

@matuzalemsteles
Copy link
Member

Yes, I'll see if I can see another way to get around this without waiting for this correction, I'll try to work on it later.

@matuzalemsteles matuzalemsteles added type: bug Issues reporting that Component is not doing what should be done comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: blocked Issues that are being blocked by other tasks labels Nov 23, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 6, 2018
@matuzalemsteles
Fixes liferay#1228 - Fixes tests and regen snapshots
cc539b8
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 6, 2018
@matuzalemsteles
Fixes liferay#1228 - Adds the soy doc
39a5afe
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 6, 2018
@matuzalemsteles
Fixes liferay#1228 - Adds tests isomorphic
6befff7
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 6, 2018
@matuzalemsteles
Fixes liferay#1228 - Regen ClayDatasetDisplay snapshots
990c383
jbalsas added a commit that referenced this issue Dec 7, 2018
@jbalsas
Merge pull request #1361 from matuzalemsteles/issue-1228
a5f692a 
Fixes #1228 - Add the .filterLabel template to a file soy separate
@matuzalemsteles matuzalemsteles added status: next-release Issues that will enter into the next release and removed status: blocked Issues that are being blocked by other tasks labels Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@4lejandrito @matuzalemsteles