Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ClayMultiSelect Component #1285

Closed
2 tasks done
matuzalemsteles opened this issue Nov 5, 2018 · 2 comments
Closed
2 tasks done

Create ClayMultiSelect Component #1285

matuzalemsteles opened this issue Nov 5, 2018 · 2 comments
Assignees
@matuzalemsteles
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: next-release Issues that will enter into the next release type: epic Issues that are opened as an Epic, that there are many things to be done

Comments

@matuzalemsteles
Copy link
Member

matuzalemsteles commented Nov 5, 2018 •
edited
Loading

Initial implementation
@matuzalemsteles matuzalemsteles self-assigned this Nov 5, 2018
@matuzalemsteles matuzalemsteles changed the title Create ClayInputField Component Create ClayLabelsInputField Component Nov 5, 2018
@matuzalemsteles
Copy link
Member Author

hey @victorvalle, The navigation between the labels is not clear to me yet. Just leaving a few points here.

  • Can I remove the label when navigating the arrows?
  • When to remove the label where the focus should be? on the label before it was removed? in input?
  • When navigation occurs by arrows can I remove the label by pressing backspace or enter?

@victorvalle
Copy link

  • Can I remove the label when navigating with the arrows?
    Yes
  • When to remove the label where the focus should be? on the label before it was removed? in input?
    in the input
  • When navigation occurs by arrows can I remove the label by pressing backspace or enter?
    both

matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 7, 2018
@matuzalemsteles
Fixes liferay#1285 - Fixes ClayLabel Event Consistency
d7de4dc
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 7, 2018
@matuzalemsteles
Fixes liferay#1285 - Update the test with the label emit the event
9630922
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 7, 2018
@matuzalemsteles
Fixes liferay#1285 - Create ClayLabelsInputField component
8e34cd1
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 7, 2018
@matuzalemsteles
Fixes liferay#1285 - SF
96f556a
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 7, 2018
@matuzalemsteles
Fixes liferay#1285 - Fixes ClayLabel Event Consistency
3e0a585
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 7, 2018
@matuzalemsteles
Fixes liferay#1285 - Update the test with the label emit the event
3d63d96
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 7, 2018
@matuzalemsteles
Fixes liferay#1285 - Create ClayLabelsInputField component
045baef
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 7, 2018
@matuzalemsteles
Fixes liferay#1285 - SF
3ce8327
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 13, 2018
@matuzalemsteles
Fixes liferay#1285 - Fixes ClayLabel Event Consistency
831d114
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 13, 2018
@matuzalemsteles
Fixes liferay#1285 - Update the test with the label emit the event
9280b30
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 13, 2018
@matuzalemsteles
Fixes liferay#1285 - Create ClayLabelsInputField component
9e458f7
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Nov 13, 2018
@matuzalemsteles
Fixes liferay#1285 - SF
75c0f9a
@matuzalemsteles matuzalemsteles added comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: epic Issues that are opened as an Epic, that there are many things to be done labels Nov 23, 2018
@matuzalemsteles matuzalemsteles changed the title Create ClayLabelsInputField Component Create ClayMultiSelect Component Nov 30, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Update the test with the label emit the event
f4aa7f6
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Create ClayLabelsInputField component
926ece9
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - SF
0df4ded
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Rename ClayLabelsInputField by ClayMultiSelect
b51ccfb
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Regen snapshots
1eccc75
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - SF
6ea3024
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Remove Label reference and replace with Item
2a3c545
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Add inputName to API
131ca6f
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Creates a new itemSelected event when select a d…
8cff801 
…ropdown item
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Update demos
498fbcf
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Add the input hidden with values the selected items
5956a75
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Move ClayMultiSelect to ClayMultiSelectBase
bcda7aa
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Move clay-multi-select/utils to clay-data-provid…
83f50af 
…er/utils
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Remove unused code and integrate with ClayAutoco…
581ad39 
…mplete
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Update demos
29027aa
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Rename ClayMultiSelectBase to ClayMultiSelect
2b7ace1
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Add doc to soy
6695ce2
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Update packages version
f6aa4d6
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Add focus to element
3dfc9f4
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Add the tabIndex API to ClayButton
0a885cf
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Add the tabIndex API to ClayLabel
25ba1ef
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Update demos
c5d54d5
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Remove the clearInput method in favor of the inp…
5e97840 
…utValue API
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Replace ref formGroupInput by autocomplete
32e8ee0
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Adds tests to cover multi select use cases
9828b52
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Update package README.md
d2a553f
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Add test to ClayButton with API use case tabIndex
7318887
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Add test to ClayLabel with API use case tabIndex
828a205
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - Removes the default tabIndex API in ClayLabel
4993706
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1341, liferay#1330, liferay#1285 - Adds tests isomorphic
88f3f32
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 4, 2018
@matuzalemsteles
Fixes liferay#1285 - SF
6370854
jbalsas added a commit that referenced this issue Dec 7, 2018
@jbalsas
Merge pull request #1351 from matuzalemsteles/APITagSelector
db39c57 
Fixes #1285, #1341, #1330 - Create ClayMultiSelector, ClayDataProvider and ClayAutocomplete
@matuzalemsteles matuzalemsteles added the status: next-release Issues that will enter into the next release label Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matuzalemsteles matuzalemsteles

Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: next-release Issues that will enter into the next release type: epic Issues that are opened as an Epic, that there are many things to be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matuzalemsteles @victorvalle