Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClayTable doesn't render the id when it is not wrapped #1390

Closed
izaera opened this issue Dec 14, 2018 · 0 comments
Closed

ClayTable doesn't render the id when it is not wrapped #1390

izaera opened this issue Dec 14, 2018 · 0 comments
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: bug Issues reporting that Component is not doing what should be done

Comments

@izaera
Copy link
Member

izaera commented Dec 14, 2018

Steps to reproduce: just create a table with wrapTable set to false and see the resulting HTML. It has no id and makes SPA fail when refreshing the page, for example.
@matuzalemsteles matuzalemsteles added type: bug Issues reporting that Component is not doing what should be done comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) labels Dec 14, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 14, 2018
@matuzalemsteles
Fixes liferay#1390 - Adds tests
50034ae
carloslancha added a commit that referenced this issue Dec 17, 2018
@carloslancha
Merge pull request #1394 from matuzalemsteles/1390
82630cc 
Fixes #1390 - Render the id when wrapTable is false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@izaera @matuzalemsteles