Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default type in Claybutton #1455

Closed
boton opened this issue Jan 18, 2019 · 0 comments
Closed

Add default type in Claybutton #1455

boton opened this issue Jan 18, 2019 · 0 comments
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done

Comments

@boton
Copy link
Member

boton commented Jan 18, 2019 •
edited
Loading

The default type attr works fine in js (via metal config) but is missing in soy.
Add default to soy to avoid differences between server and client render.
@carloslancha carloslancha added type: bug Issues reporting that Component is not doing what should be done comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) labels Jan 18, 2019
boton added a commit to boton/clay that referenced this issue Jan 18, 2019
@boton
Fixes liferay#1455 - Regen snapshots
5a4ef48
matuzalemsteles added a commit that referenced this issue Jan 21, 2019
@matuzalemsteles
Merge pull request #1456 from boton/issue-1455
6b6e811 
Fixes #1455 - Add default type in ClayButton.soy
@matuzalemsteles matuzalemsteles added the status: next-release Issues that will enter into the next release label Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@boton @carloslancha @matuzalemsteles