Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClayCard labels seem very close to each other (missing horizontal space) #429

Closed
julien opened this issue Jan 19, 2018 · 5 comments
Closed
Labels
status: next-release Issues that will enter into the next release

Comments

@julien
Copy link
Contributor

julien commented Jan 19, 2018

From this screenshot, it seems that when there are several labels in the ClayCard component; they are very close one to each other.

ClayCard

We should review this

@carloslancha
Copy link
Contributor

/cc @pat270

pat270 added a commit to pat270/clay that referenced this issue Jan 22, 2018
…-x` and `$badge-spacer-y`

Update: (liferay#429) Labels added option to configure `$label-spacer-x` and `$label-spacer-y`
@pat270
Copy link
Member

pat270 commented Jan 22, 2018

The spacing between labels and badges or any inline component depends upon whether or not white space is added between components. Soy strips white space by default, but I'm sure there will be cases in portal where we don't use this plugin that will have white space between labels. I think we should add white space between the labels and some margin to achieve the 8px spacing between labels.

jbalsas added a commit that referenced this issue Jan 22, 2018
Update: (#429) Badges added option to configure `$badge-spacer-x` and…
@yuchi
Copy link

yuchi commented Jan 23, 2018

You can explictly add spaces in Soy by using the {sp} special character.

Personally I believe the card part should either use inline-blocks or floated elements, but not a mix of the two.

@julien
Copy link
Contributor Author

julien commented Jan 23, 2018

Hey @yuchi, thanks for the heads up. I know about {sp} special character, but just wanted to know if this was the expected result.

@carloslancha
Copy link
Contributor

I'm on it 👍

jbalsas added a commit that referenced this issue Jan 24, 2018
@jbalsas jbalsas added the status: next-release Issues that will enter into the next release label Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: next-release Issues that will enter into the next release
Projects
None yet
Development

No branches or pull requests

5 participants