Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ClayCard be renamed? #430

Closed
julien opened this issue Jan 19, 2018 · 4 comments
Closed

Should ClayCard be renamed? #430

julien opened this issue Jan 19, 2018 · 4 comments

Comments

@julien
Copy link
Contributor

julien commented Jan 19, 2018

In the clay-card package, should the ClayCard component be renamed to ClayBaseCard or ClayCardBase ?

This is more a question than an issue, but @carloslancha and I were wondering what the rest of the team thought about it.
@carloslancha
Copy link
Contributor

Since ClayCard is not intended to be used standalone and in order to follow the same pattern as the rest of the component... yeah, I'd said we should rename it to ClayCardBase.

@julien
Copy link
Contributor Author

julien commented Jan 22, 2018

@carloslancha thanks for the feedback. I can take care of it if you want.

@carloslancha
Copy link
Contributor

Nice @julien !

julien pushed a commit to julien/clay that referenced this issue Jan 23, 2018
Renames ClayCard to ClayCardBase
d93af44 
Fixes liferay#430
@carloslancha
Copy link
Contributor

Resolved by #443

@julien julien closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julien @carloslancha