Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "info button" to ClayManagementToolbar #481

Closed
carloslancha opened this issue Jan 26, 2018 · 2 comments
Closed

Add "info button" to ClayManagementToolbar #481

carloslancha opened this issue Jan 26, 2018 · 2 comments
Labels
type: enhancement Issues that are open to bring improvements or refinement of code

Comments

@carloslancha
Copy link
Contributor

New feature required by UX: https://docs.google.com/document/d/1y67UAnbUzL5WLAkPMQbkqgGw3_5e7-JMEPVYdC48qE0/edit?ts=5a692baa#
@pat270
Copy link
Member

pat270 commented Jan 31, 2018

Hey Carlos, is this issue requesting a markup demo for the info button with sliding panel?

@carloslancha
Copy link
Contributor Author

carloslancha commented Feb 1, 2018 •
edited
Loading

Hey @pat270! I created the issue to implement that feature in the existing component, but would be great to add a markup to the demo to be sure we do it correctly. Thx! :D

matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 6, 2018
@matuzalemsteles
Add support the Info button to ClayManagementToolbar | Fixes liferay#481
6d81b50
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 6, 2018
@matuzalemsteles
Update demos | Fixes liferay#481
f2517c7
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 6, 2018
@matuzalemsteles
Add ref to button | Fixes liferay#481
3759f0c
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 6, 2018
@matuzalemsteles
Add tests | Fixes liferay#481
fafe4ba
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 6, 2018
@matuzalemsteles
Regen snapshots | Fixes liferay#481
56e326e
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 6, 2018
@matuzalemsteles
SF | Fixes liferay#481
9d637dd
pat270 added a commit to pat270/clay that referenced this issue Feb 8, 2018
@pat270
Update: (liferay#481) Side Navigation JS that is type relative shou…
56fbec2 
…ld push over content based on menu size and position of content on the page

Update: Side Navigation JS `.sidenav-menu` should adjust if `.sidenav-content` becomes taller than the menu

Update: Side Navigation JS `clearStyle` should accept multiple css properties

New: Side Navigation JS added option to configure `heightType`, a full height `sidenav-menu` that is as tall as the document, and deprecate `equalHeight` option
pat270 added a commit to pat270/clay that referenced this issue Feb 8, 2018
@pat270
Update: (liferay#481) Side Navigation styles .sidenav-content shoul…
41e5269 
…dn't reset `padding-left` and `padding-right`, `.sidenav-menu-slider` should have `overflow: visible` when fully open
pat270 added a commit to pat270/clay that referenced this issue Feb 8, 2018
@pat270
Site: (liferay#481) Side Navigation add docs with new items and Info …
2e5cf59 
…Panel on test pages Card, Table, List View
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Feb 9, 2018
@matuzalemsteles
Replace infoButton to showInfoButton and improve JSDOC| Fixes liferay…
cacd6aa 
…#481
pat270 added a commit to pat270/clay that referenced this issue Feb 9, 2018
@pat270
Update: (liferay#481) Side Navigation JS that is type relative shou…
9104418 
…ld push over content based on menu size and position of content on the page

Update: Side Navigation JS `.sidenav-menu` should adjust if `.sidenav-content` becomes taller than the menu

Update: Side Navigation JS `clearStyle` should accept multiple css properties

New: Side Navigation JS added option to configure `heightType`, a full height `sidenav-menu` that is as tall as the document, and deprecate `equalHeight` option
pat270 added a commit to pat270/clay that referenced this issue Feb 9, 2018
@pat270
Update: (liferay#481) Side Navigation styles .sidenav-content shoul…
86b4e34 
…dn't reset `padding-left` and `padding-right`, `.sidenav-menu-slider` should have `overflow: visible` when fully open
pat270 added a commit to pat270/clay that referenced this issue Feb 9, 2018
@pat270
Site: (liferay#481) Side Navigation add docs with new items and Info …
3d0249f 
…Panel on test pages Card, Table, List View
pat270 added a commit to pat270/clay that referenced this issue Feb 9, 2018
@pat270
Site: (liferay#481) Change info-circle-open icon in Quick Action Me…
a748484 
…nu demos to `expand` because it's confusing
pat270 added a commit to pat270/clay that referenced this issue Feb 9, 2018
@pat270
Site: (liferay#481) Add examples of Card, List, Table views with Mana…
cc71c51 
…gement Bar Primary and Info Panel
pat270 added a commit to pat270/clay that referenced this issue Feb 9, 2018
@pat270
Site: (liferay#481) Add examples of Card, List, Table views with Mana…
83e522b 
…gement Bar Primary and Info Panel
pat270 added a commit to pat270/clay that referenced this issue Feb 13, 2018
@pat270
Site: (liferay#481) Add Info Button to Management Bar Light and move …
bc44739 
…position of Info Button on Management Bar Primary
pat270 added a commit to pat270/clay that referenced this issue Feb 13, 2018
@pat270
New: (liferay#481) Nav added option to configure $nav-btn-padding-x…
7d81428 
…, `$nav-btn-padding-y` and buttons in Nav should inherit padding-x from `.btn-sm`
pat270 added a commit to pat270/clay that referenced this issue Feb 13, 2018
@pat270
Update: (liferay#481) Management Bar links and buttons spacing to 0.2…
4c6c368 
…5rem in mobile
@carloslancha carloslancha added the type: enhancement Issues that are open to bring improvements or refinement of code label Feb 16, 2018
jbalsas added a commit that referenced this issue Feb 20, 2018
@jbalsas
Merge pull request #577 from carloslancha/pr-517
469bf21 
Add "info button" to ClayManagementToolbar | Fixes #481
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Update: (liferay#481) Side Navigation JS that is type relative shou…
28bbe60 
…ld push over content based on menu size and position of content on the page

Update: Side Navigation JS `.sidenav-menu` should adjust if `.sidenav-content` becomes taller than the menu

Update: Side Navigation JS `clearStyle` should accept multiple css properties

New: Side Navigation JS added option to configure `heightType`, a full height `sidenav-menu` that is as tall as the document, and deprecate `equalHeight` option
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Update: (liferay#481) Side Navigation styles .sidenav-content shoul…
55cb3ac 
…dn't reset `padding-left` and `padding-right`, `.sidenav-menu-slider` should have `overflow: visible` when fully open
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Site: (liferay#481) Side Navigation add docs with new items and Info …
2e35075 
…Panel on test pages Card, Table, List View
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Site: (liferay#481) Change info-circle-open icon in Quick Action Me…
bf6037e 
…nu demos to `expand` because it's confusing
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Site: (liferay#481) Add examples of Card, List, Table views with Mana…
6c0f10c 
…gement Bar Primary and Info Panel
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Site: (liferay#481) Add Info Button to Management Bar Light and move …
8390cf9 
…position of Info Button on Management Bar Primary
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
New: (liferay#481) Nav added option to configure $nav-btn-padding-x…
3657c62 
…, `$nav-btn-padding-y` and buttons in Nav should inherit padding-x from `.btn-sm`
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Update: (liferay#481) Management Bar links and buttons spacing to 0.2…
9cb0f19 
…5rem in mobile
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Update: (liferay#481) Navbar added classes .navbar-nowrap, `.navbar…
ec72db3 
…-nav-expand`, `.nav-item-expand`, `.nav-item-shrink` to help with horizontal sizing of various items in Navbar
pat270 added a commit to pat270/clay that referenced this issue Feb 20, 2018
@pat270
Site: (liferay#481) Management Bar Primary demos should truncate Sele…
5a3cf05 
…ct All text
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Add support the Info button to ClayManagementToolbar | Fixes liferay#481
fb2b810
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Update demos | Fixes liferay#481
ed80d49
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Add ref to button | Fixes liferay#481
7fbb0e4
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Add tests | Fixes liferay#481
a2efd67
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
SF | Fixes liferay#481
44135e7
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
@matuzalemsteles
Replace infoButton to showInfoButton and improve JSDOC| Fixes liferay…
0121718 
…#481
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
InfoButton is not part of actionItems even in active state | Fixes li…
a7ea5e3 
…feray#481
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
Update ClayManagementToolbar demos | Fixes liferay#481
ddc1193
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
Update ClayManagementToolbar tests | Fixes liferay#481
4203949
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
Regen snapshots | Fixes liferay#481
b5c32ca
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
InfoButton in ClayManagementToolbar should be disabled in the same wa…
0eb4b40 
…y of the rest of the buttons | Fixes liferay#481
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
Update ClayManagementToolbar demos | Fixes liferay#481
75f552b
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
Update ClayManagementToolbar tests | Fixes liferay#481
338e7ff
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
Regen snapshots | Fixes liferay#481
fa9007e
jbalsas added a commit that referenced this issue Feb 22, 2018
@jbalsas
Merge pull request #612 from carloslancha/pr-523
ddc7753 
Regen snapshots | Fixes #481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pat270 @carloslancha