Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upadte styles for new Clay Card Grid List Markup #542

Closed
carloslancha opened this issue Feb 9, 2018 · 1 comment
Closed

Upadte styles for new Clay Card Grid List Markup #542

carloslancha opened this issue Feb 9, 2018 · 1 comment
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done

Comments

@carloslancha
Copy link
Contributor

We changed a little the markup of the ClayCardGrid component in order to be like ClayList's one and to fix some issues with the soy compilation. We need to update Clay's demos and add (if needed) styles to make it looks fine again.

Here the new markup:

<ul class="card-page">
	<li>
		<h4 class="card-section-header">Folders</h4>
	</li>
	<li class="card-page-item-directory">
		<div class="card-type-directory......></div>
	</li>
	<li class="card-page-item-directory">
		<div class="card-type-directory......></div>
	</li>
	<li>
		<h4 class="card-section-header">Recipes</h4>
	</li>
	<li class="card-page-item-asset">
		<div class="card-type-asset......></div>
	</li>
	<li class="card-page-item-asset">
		<div class="card-type-asset......></div>
	</li>
</ul>

@pat270 If we need to add classes to any element in this markup just let us know. Thx!

@carloslancha carloslancha added the type: bug Issues reporting that Component is not doing what should be done label Feb 9, 2018
@carloslancha
Copy link
Contributor Author

Hey @pat270 could you take a look on this please? 😃

pat270 added a commit to pat270/clay that referenced this issue Feb 17, 2018
pat270 added a commit to pat270/clay that referenced this issue Feb 17, 2018
carloslancha added a commit that referenced this issue Feb 17, 2018
(#542) Put `card-section-header` inside `card-page li`
matuzalemsteles added a commit that referenced this issue Feb 19, 2018
Update styles for new Clay Card Grid List Markup | Fixes #542
@carloslancha carloslancha added the status: next-release Issues that will enter into the next release label Feb 19, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
kienD pushed a commit to kienD/clay that referenced this issue Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Development

No branches or pull requests

1 participant