Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

point.focus.expand.r expects a boolean but the correct one is number in ClayCharts #853

Closed
matuzalemsteles opened this issue Apr 26, 2018 · 0 comments
Closed

point.focus.expand.r expects a boolean but the correct one is number in ClayCharts #853

matuzalemsteles opened this issue Apr 26, 2018 · 0 comments
Assignees
@matuzalemsteles
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Milestone
2.0.1

Comments

@matuzalemsteles
Copy link
Member

According to the descriptions of the billboard API it expects a Boolean but does not work, but the description of it assumes that it expects a Number and the default value is a Number, this works.
@matuzalemsteles matuzalemsteles added the type: bug Issues reporting that Component is not doing what should be done label Apr 26, 2018
@matuzalemsteles matuzalemsteles self-assigned this Apr 26, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Apr 26, 2018
@matuzalemsteles
Set the expected of point.focus.expand.r to Number | Fixes liferay#853
2276050
jbalsas added a commit that referenced this issue Apr 26, 2018
@jbalsas
Merge pull request #855 from matuzalemsteles/issue-853
9ecbb76 
Set the expected from point.focus.expand.r to Number | Fixes #853
@jbalsas jbalsas added the status: next-release Issues that will enter into the next release label Apr 26, 2018
@jbalsas jbalsas added this to the 2.0.1 milestone Apr 26, 2018
@jbalsas jbalsas closed this as completed in 13d4a88 May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matuzalemsteles matuzalemsteles

Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
2 participants
@jbalsas @matuzalemsteles