Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClayDropdown should close when clicked on document on mobile and others #956

Closed
matuzalemsteles opened this issue May 29, 2018 · 0 comments
Closed

ClayDropdown should close when clicked on document on mobile and others #956

matuzalemsteles opened this issue May 29, 2018 · 0 comments
Assignees
@matuzalemsteles
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done type: enhancement Issues that are open to bring improvements or refinement of code
Milestone
2.1.6

Comments

@matuzalemsteles
Copy link
Member

Summary

ClayDropdown currently only listens to document events to close the dropdown.

Expected behavior

The dropdown should close in the following use cases:

  • Dropdown should close when clicked on document on mobile
  • When pressing ESC you should close the dropdown *
  • The dropdown should close when you click on an iframe on the screen *

NOTE: * These are use cases collected from LPS-81389

Current behavior

The dropdown does not close in the above use cases.
@matuzalemsteles matuzalemsteles added type: bug Issues reporting that Component is not doing what should be done type: enhancement Issues that are open to bring improvements or refinement of code labels May 29, 2018
@matuzalemsteles matuzalemsteles self-assigned this May 29, 2018
@matuzalemsteles matuzalemsteles added this to the 2.1.5 milestone May 29, 2018
@carloslancha carloslancha modified the milestones: 2.1.5, 2.1.6 May 30, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 30, 2018
@matuzalemsteles
Adding touchend event | Fixes liferay#956
457206f
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 30, 2018
@matuzalemsteles
Listening to document events only when the dropdown is open | Fixes l…
0754d60 
…iferay#956
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 30, 2018
@matuzalemsteles
Adding blur event to window to access activeElement | Fixes liferay…
0608afe 
…#956
@carloslancha carloslancha added the status: next-release Issues that will enter into the next release label May 31, 2018
@jbalsas jbalsas closed this as completed in 6be8bd4 Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matuzalemsteles matuzalemsteles

Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done type: enhancement Issues that are open to bring improvements or refinement of code
Projects
None yet
Milestone
2.1.6
Development

No branches or pull requests
2 participants
@carloslancha @matuzalemsteles