Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the links on clayui.com and more | Fixes #1070 #1071

Merged
merged 3 commits into from
Aug 20, 2018

Conversation

matuzalemsteles
Copy link
Member

No description provided.

@matuzalemsteles matuzalemsteles changed the title Fixes the links on clayui.com and more Fixes the links on clayui.com and more | Fixes #1070 Aug 6, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1055

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 80.664%

Files with Coverage Reduction New Missed Lines %
packages/generator-metal-clay/app/index.js 25 15.0%
Totals Coverage Status
Change from base Build 1049: -0.3%
Covered Lines: 5106
Relevant Lines: 5509

💛 - Coveralls

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@@ -45,7 +45,7 @@ You can call Clay components in your SOY templates the same way you would call a
<div class="alert alert-warning" role="alert">
<span class="alert-indicator">
<svg aria-hidden="true" class="lexicon-icon lexicon-icon-warning-full">
<use xlink:href="/vendor/lexicon/icons.svg#warning-full"></use>
<use xlink:href="/images/icons/icons.svg#warning-full"></use>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon doesn't appear

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @carloslancha, this is strange, this appears to me. I have tested in production and development environment.

screen shot 2018-08-08 at 10 19 55

Could you check again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, it's working, don't know why it didn't appear before. Thx

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha carloslancha merged commit cf40ecd into liferay:develop Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants