Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove script electric from root #1073

Merged
merged 4 commits into from
Aug 9, 2018

Conversation

matuzalemsteles
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Aug 7, 2018

Pull Request Test Coverage Report for Build 1062

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 80.922%

Files with Coverage Reduction New Missed Lines %
packages/clay-charts/src/ChartBase.js 29 75.31%
Totals Coverage Status
Change from base Build 1049: 0.0%
Covered Lines: 5131
Relevant Lines: 5509

💛 - Coveralls

Copy link
Contributor

@carloslancha carloslancha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I'd leave only one task that runs everything needed to launch the site:

"site": "cd clayui.com && npm run build && npm run serve"

To develop make sense to enter into the folder and play from there. What do you think?

Also, we need to document this task in the README.

@matuzalemsteles
Copy link
Member Author

hey @carloslancha, this looks better. Thanks for remembering.

@carloslancha carloslancha merged commit 4db6de7 into liferay:develop Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants